[EXTERNAL] Re: [PATCH v5] cnxk: disable building template files
Jerin Jacob
jerinjacobk at gmail.com
Wed May 29 10:01:39 CEST 2024
On Tue, May 28, 2024 at 3:31 PM Pavan Nikhilesh Bhagavatula
<pbhagavatula at marvell.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Bruce Richardson <bruce.richardson at intel.com>
> > Sent: Tuesday, May 28, 2024 3:10 PM
> > To: Pavan Nikhilesh Bhagavatula <pbhagavatula at marvell.com>
> > Cc: Jerin Jacob <jerinj at marvell.com>; Nithin Kumar Dabilpuram
> > <ndabilpuram at marvell.com>; Kiran Kumar Kokkilagadda
> > <kirankumark at marvell.com>; Sunil Kumar Kori <skori at marvell.com>; Satha
> > Koteswara Rao Kottidi <skoteshwar at marvell.com>; Harman Kalra
> > <hkalra at marvell.com>; Shijith Thotton <sthotton at marvell.com>; Anatoly
> > Burakov <anatoly.burakov at intel.com>; dev at dpdk.org
> > Subject: Re: [EXTERNAL] Re: [PATCH v5] cnxk: disable building template files
> >
> > On Tue, May 28, 2024 at 09:23:12AM +0000, Pavan Nikhilesh Bhagavatula
> > wrote:
> > > > On Mon, May 27, 2024 at 09:04:29PM +0530,
> > pbhagavatula at marvell.com
> > > > wrote:
> > > > > From: Pavan Nikhilesh <pbhagavatula at marvell.com>
> > > > >
> > > > > Disable building template files when CNXK_DIS_TMPLT_FUNC is defined
> > > > > as a part of c_args. This option can be used when reworking datapath
> > > > > or debugging issues to reduce Rx/Tx path compilation time.
> > > > >
> > > > > Example command: meson build -Dc_args='-DCNXK_DIS_TMPLT_FUNC'
> > > > > -Dexamples=all --cross-file config/arm/arm64_cn10k_linux_gcc
> > > > >
> > > > Should this option be set in CI by default, or in test-meson-builds by
> > > > default? When do we need to avoid setting this flag, vs setting it?
> > > >
> > >
> > > Yes, we can set this option when testing builds to speed things up. We
> > > would want to avoid setting the flag when we are packaging or generating
> > > release binaries as it will negatively affect fastpath performance.
> > >
> > > I am not sure how to integrate to test-meson-builds as there is no target
> > > option for cn10k/cn9k.
> > >
> > So, are these template files already not built when building for other
> > platforms other than cn10k/cn9k?
>
> I rechecked they are only built when target is aarch64.
Bruce, planning to merge this patch. Please let me know if there is a
difference in opinion.
More information about the dev
mailing list