[PATCH v5 2/2] eal: initialize shared plugins on Windows

[Thomas Monjalon]

29/05/2024 19:56, Tyler Retzlaff:
> On Wed, May 29, 2024 at 04:29:29PM +0200, Thomas Monjalon wrote:
> > 12/03/2024 17:52, Tyler Retzlaff:
> > > When EAL is built with MSVC it is possible to dynamically load plugins
> > > on Windows. Hook eal_plugins_init into rte_eal_init if built with MSVC
> > > and provide code to load plugins on Windows.
> > > 
> > > Signed-off-by: Tyler Retzlaff <roretzla at linux.microsoft.com>
> > > Acked-by: Dmitry Kozlyuk <dmitry.kozliuk at gmail.com>
> > > ---
> > > +#ifdef RTE_EXEC_ENV_WINDOWS
> > > +static void*
> > > +eal_dlopen(const char *pathname)
> > > +{
> > 
> > I'm not sure about having a Windows-specific implementation in lib/eal/common/
> 
> are you asking for the unix and windows implementations to be moved out
> to eal/{windows,unix} respectively rather than the current conditional
> compiled in eal/common?

Yes I feel it would be better.
Please tell me if I missed something.

> > Also, the CI is failing with this patchset.
> > 
> 
> i'll take a look when i get a chance, you can leave it unmerged for now.