[PATCH] Revert "bus/vdev: fix devargs in secondary process"

Stephen Hemminger stephen at networkplumber.org
Fri May 31 19:41:18 CEST 2024


This reverts commit 6666628362c94a0b567a39a0177539c12c97d999.

That commit broke use of dumpcap with vdev's and probably
other uses of secondary processes with vdev as well.

Bugzilla ID: 1450

Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
---
 drivers/bus/vdev/vdev.c | 22 +---------------------
 1 file changed, 1 insertion(+), 21 deletions(-)

diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c
index 14cf856237..05582f1727 100644
--- a/drivers/bus/vdev/vdev.c
+++ b/drivers/bus/vdev/vdev.c
@@ -263,22 +263,6 @@ alloc_devargs(const char *name, const char *args)
 	return devargs;
 }
 
-static struct rte_devargs *
-vdev_devargs_lookup(const char *name)
-{
-	struct rte_devargs *devargs;
-	char dev_name[32];
-
-	RTE_EAL_DEVARGS_FOREACH("vdev", devargs) {
-		devargs->bus->parse(devargs->name, &dev_name);
-		if (strcmp(dev_name, name) == 0) {
-			VDEV_LOG(INFO, "devargs matched %s", dev_name);
-			return devargs;
-		}
-	}
-	return NULL;
-}
-
 static int
 insert_vdev(const char *name, const char *args,
 		struct rte_vdev_device **p_dev,
@@ -291,11 +275,7 @@ insert_vdev(const char *name, const char *args,
 	if (name == NULL)
 		return -EINVAL;
 
-	if (rte_eal_process_type() == RTE_PROC_PRIMARY)
-		devargs = alloc_devargs(name, args);
-	else
-		devargs = vdev_devargs_lookup(name);
-
+	devargs = alloc_devargs(name, args);
 	if (!devargs)
 		return -ENOMEM;
 
-- 
2.43.0



More information about the dev mailing list