[PATCH v2 4/5] dts: add `show port info` command to TestPmdShell

Jeremy Spewock jspewock at iol.unh.edu
Fri May 31 23:06:53 CEST 2024


All looks good to me, with one documentation nit-pick

On Thu, May 9, 2024 at 7:26 AM Luca Vizzarro <luca.vizzarro at arm.com> wrote:
>
> Add a new TestPmdPort data structure to represent the output
> returned by `show port info`, which is implemented as part of
> TestPmdShell.
>
> The TestPmdPort data structure and its derived classes are modelled
> based on the relevant testpmd source code.
>
> This implementation makes extensive use of regular expressions, which
> all parse individually. The rationale behind this is to lower the risk
> of the testpmd output changing as part of development. Therefore
> minimising breakage.
>
> Bugzilla ID: 1407
>
> Signed-off-by: Luca Vizzarro <luca.vizzarro at arm.com>
> Reviewed-by: Paul Szczepanek <paul.szczepanek at arm.com>
> ---
<snip>
> +class DeviceCapabilitiesFlag(Flag):
> +    """Flag representing the device capabilities."""
> +
> +    RUNTIME_RX_QUEUE_SETUP = auto()
> +    """Device supports Rx queue setup after device started."""
> +    RUNTIME_TX_QUEUE_SETUP = auto()
> +    """Device supports Tx queue setup after device started."""
> +    RXQ_SHARE = auto()
> +    """Device supports shared Rx queue among ports within Rx domain and switch domain."""
> +    FLOW_RULE_KEEP = auto()
> +    """Device supports keeping flow rules across restart."""
> +    FLOW_SHARED_OBJECT_KEEP = auto()
> +    """Device supports keeping shared flow objects across restart."""
> +

In the other flag classes it looks like these doc-strings were changed
to be in the class var format (`#:`), but these might have been missed
when going through and changing the others.

> +    @classmethod
> +    def make_parser(cls) -> ParserFn:
<snip>
> 2.34.1
>


More information about the dev mailing list