[PATCH v3 1/4] net/nfp: fix port index problem

Stephen Hemminger stephen at networkplumber.org
Fri Nov 1 04:44:06 CET 2024


On Fri,  1 Nov 2024 10:57:10 +0800
Chaoyong He <chaoyong.he at corigine.com> wrote:

> @@ -1022,6 +1025,7 @@ nfp_flower_pf_repr_alloc(struct nfp_net_hw_priv *hw_priv,
>  
>  	/* Create a rte_eth_dev for PF vNIC representor */
>  	flower_repr->repr_type = NFP_REPR_TYPE_PF;
> +	flower_repr->idx = 0;

That initialization does not look like it necessary since that structure
was initialized at start of the function.  Might be better to put all the init
for the data structure there, to avoid confusion.


More information about the dev mailing list