[PATCH v5 09/18] net/r8169: add support for hw initialization

Ferruh Yigit ferruh.yigit at amd.com
Sun Nov 3 03:19:26 CET 2024


On 10/28/2024 7:31 AM, Howard Wang wrote:
> Signed-off-by: Howard Wang <howard_wang at realsil.com.cn>
> 

Can you please add some description to the commit log?

<...>

> diff --git a/drivers/net/r8169/r8169_phy.h b/drivers/net/r8169/r8169_phy.h
> index 1d8889f8dc..2576538a00 100644
> --- a/drivers/net/r8169/r8169_phy.h
> +++ b/drivers/net/r8169/r8169_phy.h
> @@ -24,8 +24,8 @@
>  #define MII_EXPANSION		0x06	/* Expansion register          */
>  #define MII_CTRL1000		0x09	/* 1000BASE-T control          */
>  #define MII_STAT1000		0x0a	/* 1000BASE-T status           */
> -#define MII_MMD_CTRL		0x0d	/* MMD Access Control Register */
> -#define MII_MMD_DATA		0x0e	/* MMD Access Data Register    */
> +#define	MII_MMD_CTRL		0x0d	/* MMD Access Control Register */
> +#define	MII_MMD_DATA		0x0e	/* MMD Access Data Register    */
>

This seems unintendent modification.


More information about the dev mailing list