[PATCH] app/dumpcap: remove unused struct array

David Marchand david.marchand at redhat.com
Wed Nov 6 21:35:25 CET 2024


On Wed, Nov 6, 2024 at 7:18 PM Stephen Hemminger
<stephen at networkplumber.org> wrote:
>
> On Tue,  5 Nov 2024 11:27:21 +0000
> Bruce Richardson <bruce.richardson at intel.com> wrote:
>
> > The callbacks(rx_cb) member of struct interface was unused inside
> > dumpcap, but was taking up a lot of memory space, since it was scaled
> > according to RTE_MAX_QUEUES_PER_PORT, which is 1k by default. Save
> > memory by removing the whole array.
> >
> > Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application")
> > Cc: stable at dpdk.org
> >
> > Suggested-by: Stephen Hemminger <stephen at networkplumber.org>
> > Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
> Acked-by: Stephen Hemminger <stephen at networkplumber.org>

Applied, thanks.

-- 
David Marchand



More information about the dev mailing list