[PATCH] test/fib: clarify FIB RCU negative tests

Medvedkin, Vladimir vladimir.medvedkin at intel.com
Thu Nov 7 18:02:36 CET 2024


Hi David,

On 07/11/2024 13:00, David Marchand wrote:
> On Wed, Oct 16, 2024 at 8:42 PM Vladimir Medvedkin
> <vladimir.medvedkin at intel.com> wrote:
>> @@ -445,7 +454,7 @@ test_invalid_rcu(void)
>>          rcu_cfg.v = qsv2;
>>          rcu_cfg.mode = RTE_FIB_QSBR_MODE_SYNC;
>>          status = rte_fib_rcu_qsbr_add(fib, &rcu_cfg);
>> -       RTE_TEST_ASSERT(status != 0, "Secondary RCU was mistakenly attached\n");
>> +       RTE_TEST_ASSERT(status = -EEXIST, "Secondary RCU was mistakenly attached\n");
> My eyes stopped on this.
> Should be == right?

You right, thanks!

Will send v2

>
>>          rte_fib_free(fib);
>>          rte_free(qsv);
>
-- 
Regards,
Vladimir



More information about the dev mailing list