[PATCH v6 01/17] net/r8169: add PMD driver skeleton

[Ferruh Yigit]

On 11/8/2024 12:11 PM, Howard Wang wrote:
> Meson build infrastructure, r8169_ethdev minimal skeleton,
> header with Realtek NIC device and vendor IDs.
> 
> Signed-off-by: Howard Wang <howard_wang at realsil.com.cn>

<...>

> +/*
> + * The set of PCI devices this driver supports
> + */
> +static const struct rte_pci_id pci_id_r8169_map[] = {
> +	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x8125) },
> +	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x8162) },
> +	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x8126) },
> +	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x5000) },
>

What do you think to add macros for the PCI device IDs, naming them
makes it easier to know which devices are supported.

<...>

> +
> +#define RTL_DEV_PRIVATE(eth_dev) \
> +	((struct rtl_adapter *)((eth_dev)->data->dev_private))
> +
> 

This macro is only used a few patches later, what do you think to add
this macro when used?