[PATCH 2/2] common/dpaax: do not disable fallthrough warnings
Hemant Agrawal
hemant.agrawal at oss.nxp.com
Thu Nov 14 07:06:46 CET 2024
On 14-11-2024 06:06, Stephen Hemminger wrote:
> Fallthrough warnings catch real bugs and should not be disabled.
> There are warnings in this driver in current build.
>
> The commit that added the disable is old, and the problematic code
> appears to have been already removed.
>
> Fixes: 2ab9a9483196 ("crypto/dpaa2_sec: fix build with GCC 7")
> Cc: thomas at monjalon.net
>
> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> ---
> drivers/common/dpaax/caamflib/rta/operation_cmd.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/common/dpaax/caamflib/rta/operation_cmd.h b/drivers/common/dpaax/caamflib/rta/operation_cmd.h
> index fe1ac37ee8..563735eb88 100644
> --- a/drivers/common/dpaax/caamflib/rta/operation_cmd.h
> +++ b/drivers/common/dpaax/caamflib/rta/operation_cmd.h
> @@ -7,10 +7,6 @@
> #ifndef __RTA_OPERATION_CMD_H__
> #define __RTA_OPERATION_CMD_H__
>
> -#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION >= 70000)
> -#pragma GCC diagnostic ignored "-Wimplicit-fallthrough"
> -#endif
> -
> extern enum rta_sec_era rta_sec_era;
>
> static inline int
Acked-by: Hemant Agrawal <hemant.agrawal at nxp.com>
More information about the dev
mailing list