bug in cryptodev enqueue/dequeue callbacks?

Konstantin Ananyev konstantin.ananyev at huawei.com
Thu Nov 14 15:41:05 CET 2024


Hi everyone,

Looking at implementation of cryptodev callbacks
(it uses DPDK RCU), it seems like there is a bug here:

at init time we don't call rte_rcu_qsbr_thread_register().
As I understand without it rte_rcu_qsbr_check() wouldn't
work properly for that thread.

Probably need to add:
static int
cryptodev_cb_init(struct rte_cryptodev *dev)
{
 	....
	if (rte_rcu_qsbr_init(qsbr, max_threads)) {...}
+	rte_rcu_qsbr_thread_register(qsbr, 0);		

Unless I am missing something obvious here?
Konstantin



More information about the dev mailing list