答复: [PATCH v8 12/17] net/r8169: implement Tx path

[王颢]

Dear Thomas,

I will consider that. By the way, should I make the changes and then upload patch v9?

Thanks!

-----邮件原件-----
发件人: Thomas Monjalon <thomas at monjalon.net> 
发送时间: 2024年11月18日 22:59
收件人: pro_nic_dpdk at realtek.com; 王颢 <howard_wang at realsil.com.cn>
抄送: dev at dpdk.org; Ferruh Yigit <ferruh.yigit at amd.com>
主题: Re: [PATCH v8 12/17] net/r8169: implement Tx path


External mail.



Hello,

13/11/2024 10:28, Howard Wang:
> +static u32
> +rtl_get_opts1(struct rtl_tx_desc *txd) {
> +       rte_smp_rmb();
> +
> +       return rte_le_to_cpu_32(txd->opts1); }

We should avoid using such heavy memory barrier.
Is it possible to use a lighter fence or atomic API?