[PATCH v3] rcu: shift 64-bit constant to avoid implicit 32 to 64 bit conversion

Thomas Monjalon thomas at monjalon.net
Tue Nov 19 10:26:13 CET 2024


15/11/2024 17:18, Stephen Hemminger:
> On Fri, 15 Nov 2024 07:25:30 -0800
> Andre Muezerie <andremue at linux.microsoft.com> wrote:
> 
> > From reading the code this is also a bugfix:
> > (1 << id), where id = thread_id & 0x3f, was wrong when thread_id > 0x1f.
> 
> Since this seems to be a common anti-pattern in DPDK,
> I wonder if coccinelle is smart enough to be able to make a script for these?

A simple grep '1UL << ' would do it as well.
We could add a checkpatch warning for this pattern.





More information about the dev mailing list