[PATCH v9 18/21] build: enable vla warnings on Windows built code

Andre Muezerie andremue at linux.microsoft.com
Thu Nov 21 19:11:13 CET 2024


On Wed, Nov 20, 2024 at 09:20:29AM -0800, Stephen Hemminger wrote:
> On Tue, 19 Nov 2024 17:54:43 -0800
> Andre Muezerie <andremue at linux.microsoft.com> wrote:
> 
> > From: Tyler Retzlaff <roretzla at linux.microsoft.com>
> > 
> > MSVC does not support optional C11 VLAs. When building for Windows
> > enable -Wvla so that mingw and clang also fail if a VLA is used.
> > 
> > Signed-off-by: Tyler Retzlaff <roretzla at linux.microsoft.com>
> > ---
> 
> It would be good to catch VLA's in new code even if not on Windows.
> Some parts like testpmd and eal should have it enabled

That sounds like a good idea for further improvement. I would like
to keep that out of scope for this series though, so that other work
can be unblocked, if that is OK.

Regards,
Andre


More information about the dev mailing list