[PATCH] net/mlx5: fix the unneeded stub table allocation
Dariusz Sosnowski
dsosnowski at nvidia.com
Tue Nov 26 11:38:17 CET 2024
> -----Original Message-----
> From: Bing Zhao <bingz at nvidia.com>
> Sent: Tuesday, November 26, 2024 10:26
> To: Dariusz Sosnowski <dsosnowski at nvidia.com>; Slava Ovsiienko
> <viacheslavo at nvidia.com>; dev at dpdk.org; Raslan Darawsheh
> <rasland at nvidia.com>
> Cc: Ori Kam <orika at nvidia.com>; Suanming Mou <suanmingm at nvidia.com>;
> Matan Azrad <matan at nvidia.com>; Maayan Kashani
> <mkashani at nvidia.com>
> Subject: [PATCH] net/mlx5: fix the unneeded stub table allocation
>
> The HWS non-template flow API is reusing some implementation of template
> API to unifiy code logic. So for each rule creation, a stub / temporary table is
> used in order to reuse the actions construction.
>
> Since this is temporary and used only internally, there is no need to save the
> table permanently. Only parts of them are mandatory, so the allocation / free
> from the heap of RTE memory is a waste and causes a lot of overhead. By
> using the pre-allocated workspace and set the needed fields expliticly will save
> the overhead and help to speed up the rule insertion rate.
>
> Fixes: 27d171b88031 ("net/mlx5: abstract flow action and enable
> reconfigure")
> Cc: mkashani at nvidia.com
>
> Signed-off-by: Bing Zhao <bingz at nvidia.com>
Acked-by: Dariusz Sosnowski <dsosnowski at nvidia.com>
Best regards,
Dariusz Sosnowski
More information about the dev
mailing list