[PATCH v2 03/14] net/dpaa: remove broken debug macros

[Thomas Monjalon]

12/09/2024 10:26, David Marchand:
> Those debug macros never worked as existing callers never passed a
> 'level' argument.
> Remove them.
> 
> Signed-off-by: David Marchand <david.marchand at redhat.com>
> ---
>  drivers/net/dpaa/fmlib/fm_ext.h | 21 ++-------------------
>  1 file changed, 2 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/net/dpaa/fmlib/fm_ext.h b/drivers/net/dpaa/fmlib/fm_ext.h
> index 8e7153bdaf..4666fa3b0b 100644
> --- a/drivers/net/dpaa/fmlib/fm_ext.h
> +++ b/drivers/net/dpaa/fmlib/fm_ext.h
> @@ -15,25 +15,8 @@
>  #define MODULE_FM		0x00010000
>  #define __ERR_MODULE__		MODULE_FM
>  
> -/* #define FM_LIB_DBG */
> -
> -#if defined(FM_LIB_DBG)
> -	#define _fml_dbg(fmt, args...) \
> -	rte_log(RTE_LOG_ ## level, dpaa_logtype_pmd, "fmlib:%s(): " fmt "\n", \
> -			__func__, ##args)
> -#else
> -	#define _fml_dbg(arg...)
> -#endif
> -
> -/*#define FM_IOCTL_DBG*/
> -
> -#if defined(FM_IOCTL_DBG)
> -	#define _fm_ioctl_dbg(fmt, args...) \
> -	rte_log(RTE_LOG_ ## level, dpaa_logtype_pmd, "fmioc:%s(): " fmt "\n", \
> -				__func__, ##args)
> -#else
> -	#define _fm_ioctl_dbg(arg...)
> -#endif
> +#define _fml_dbg(...)
> +#define _fm_ioctl_dbg(...)

Why not removing the calls to these macros?