[PATCH v2 03/14] net/dpaa: remove broken debug macros

Hemant Agrawal hemant.agrawal at oss.nxp.com
Tue Oct 1 15:00:30 CEST 2024


On 01-10-2024 17:38, David Marchand wrote:
> On Tue, Oct 1, 2024 at 12:19 PM Thomas Monjalon <thomas at monjalon.net> wrote:
>> 12/09/2024 10:26, David Marchand:
>>> Those debug macros never worked as existing callers never passed a
>>> 'level' argument.
>>> Remove them.
>>>
>>> Signed-off-by: David Marchand <david.marchand at redhat.com>
>> Why not removing the calls to these macros?
> I was unclear if the fmlib enters the "base driver" category.
> So I simply removed macros from the header providing wrappers to dpdk API.
>
> Relooking, I see other changes in this directory, so I agree I may as
> well remove those calls.
>
> Hemant, opinion?
>
Yes, fmlib is a common base library. So, it is better to not remove the 
calls.  Otherwise, we have to maintain the changes from base.

with that

Reviewed-by:  Hemant Agrawal <hemant.agrawal at nxp.com>




More information about the dev mailing list