[PATCH v4] eal: add build-time option to omit trace

Morten Brørup mb at smartsharesystems.com
Tue Oct 1 16:14:22 CEST 2024


> From: Jerin Jacob [mailto:jerinjacobk at gmail.com]
> Sent: Tuesday, 1 October 2024 16.05
> 
> On Tue, Oct 1, 2024 at 7:19 PM Morten Brørup <mb at smartsharesystems.com>
> wrote:
> >
> > Jerin,
> >
> > If you have no further comments, please add review/ack tag, to help
> Thomas see that the patch has been accepted by the maintainer, and can
> be merged.
> 
> There was a comment to make the function as rte_trace_is_enabled() and
> remove internal. The rest looks good to me. I will Ack in the next
> version.

Perhaps my reply to that comment was unclear... such a public function already exists in the previous API:
https://elixir.bootlin.com/dpdk/v24.07/source/lib/eal/include/rte_trace.h#L36

That function tells if trace enabled at both build time and runtime, and returns false if not.

A separate public function to tell if trace is enabled at build time seems like overkill to me. Is that what you are asking for?



More information about the dev mailing list