[PATCH v2] service: extend service function call statistics

Mattias Rönnblom hofors at lysator.liu.se
Wed Oct 2 21:43:38 CEST 2024


On 2024-10-02 21:08, David Marchand wrote:
> On Wed, Oct 2, 2024 at 8:57 PM Mattias Rönnblom <hofors at lysator.liu.se> wrote:
>>> Coverity flagged this patch with issue #445158.
>>> rte_delay_ms() is now unreachable.
>>>
>>> I suppose this delay is not that important for the unit test and we
>>> can remove it, but as I am not sure I'll let you have a look and send
>>> a fix.
>>>
>>
>> It works without it I think, but I would keep it, and add it to the
>> "case 0" branch.
>>
>> Let me know if you want a v2.
> 
> Unfortunately, coverity is run only for merged stuff.
> So the report we got is for merged patch in the main repo.
> 
> Please send a fix.
> 

Done.

I decided I could just as well reintroduce the old behavior. You could 
refactor away all this sleeping business I think, but that is for 
another day.



More information about the dev mailing list