[PATCH dpdk v2 1/2] telemetry: add api to register command with private argument

Robin Jarry rjarry at redhat.com
Thu Oct 3 14:43:30 CEST 2024


Robin Jarry, Oct 03, 2024 at 14:36:
>>> +typedef int (*telemetry_arg_cb)(const char *cmd, const char *params,
>>> +		struct rte_tel_data *info, void *arg);
>>> +
>>
>> Not sure about this, but I'd tend to have the arg parameter as second
>> parameter, to keep the "info" as the final parameter. My suggested order
>> would be: (cmd, arg, params, info)
>
> I don't have any objections. I'll send a v3.

Reflecting back, I think the void* arg would fit better as the first 
callback argument. Thoughts?



More information about the dev mailing list