[PATCH v12 1/7] buildtools/chkincs: relax C linkage requirement

[Thomas Monjalon]

04/10/2024 13:51, Robin Jarry:
> Mattias Rönnblom, Oct 04, 2024 at 10:40:
> > Making small scripts needlessly complicated is not good example, it's a 
> > bad one.
> 
> I don't find adding argument checks needlessly complicated but this is 
> a matter of preference. To me, Python is not shell script. If you want 
> something small, shell might be more appropriate?
> 
> >>> Sure, but it would be required to invoke the script for every header 
> >>> file in the tree. Not sure I think that would be a net gain.
> >> 
> >> You can store a global exit status in the script and process all headers 
> >> before exiting with an error if any.
> >
> > You will need to give the user a list of offending header files.
> 
> I'm not suggesting to avoid printing the offending file names. I'm only 
> suggesting to exit(1) if there were *any* offending file names. That way 
> you don't have to check *in meson* if the script did output anything. 
> Checking the exit status is simpler.
> 
> Sorry for being pedantic, but Python code in DPDK is already treated 
> badly. I wish we could improve the quality a bit.

Thank you Robin for your detailed review.
I support this effort of improving our Python scripts.