[PATCH 00/10] require checking ethdev get return value
Stephen Hemminger
stephen at networkplumber.org
Fri Oct 4 18:21:47 CEST 2024
Several places flagged by Coverity and Codeql are from code that
calls rte_eth_dev_info_get() but does not check the return value.
If rte_eth_dev_info_get() returns an error, the device info is garbage.
This patch series uses the function attribute to force code
to check the result or there will be a compiler warning.
The series is ordered to fix the current warnings first
before enabling it.
Stephen Hemminger (10):
app/test: remove redundant call
net/memif: check return value from rte_eth_dev_info_get
graph: check return value from rte_eth_dev_info_get
examples/ethtool: handle devices without registers
examples/l3fwd: check return value from ethdev info
examples/ntb: always check return value
examples/pipeline: check return value of ethdev functions
examples/qos_sched: check return value from rte_eth_link_get
ethdev: check return value from rte_eth_dev_info_get
ethdev: require checking results of info_get functions
app/graph/ethdev.c | 20 ++++++++++++----
app/test/test_link_bonding_rssconf.c | 1 -
drivers/net/memif/rte_eth_memif.c | 12 ++++++++--
examples/ethtool/lib/rte_ethtool.c | 6 ++---
examples/l3fwd-graph/main.c | 12 ++++++++--
examples/l3fwd/l3fwd_fib.c | 16 +++++++++----
examples/l3fwd/l3fwd_lpm.c | 14 ++++++++----
examples/ntb/ntb_fwd.c | 5 +++-
examples/pipeline/cli.c | 7 +++---
examples/qos_sched/init.c | 13 +++++++++--
lib/ethdev/rte_class_eth.c | 4 +++-
lib/ethdev/rte_ethdev.h | 34 +++++++++++++++++-----------
12 files changed, 103 insertions(+), 41 deletions(-)
--
2.45.2
More information about the dev
mailing list