[PATCH] doc: update TAP device features
Ferruh Yigit
ferruh.yigit at amd.com
Sun Oct 6 22:36:31 CEST 2024
On 10/4/2024 9:48 PM, Stephen Hemminger wrote:
> On Fri, 4 Oct 2024 02:48:21 +0100
> Ferruh Yigit <ferruh.yigit at amd.com> wrote:
>
>>> +Stats per queue = Y
>>>
>>
>> This feature name is misleading,
>> it is for 'rte_eth_dev_set_[rt]x_queue_stats_mapping()' API, which is
>> indeed for covering limitation for some drivers.
>> Tap does support getting stats per queue, but doesn't support above
>> documented feature.
>
> Just looked and the current state of the feature matrix is not correct
> for this part of the table. Although the feature intro says it is
> stats per queue mapping, that is not what other drivers are doing.
>
> Only these drivers have queue_stats_mapping_set:
> cnxk, enic, igc, ixgbe, txgbe, virtio
>
> These drivers claim to have 'Stats per queue' but do not have stats mapping:
> af_xdp, ark, atlantic, avp, bnxt, cxgbe, failsafe, fm10, hinic, hns3,
> ionic, mlx4, mlx5, netvsc, nfb, nfp, ngbe, qede, thunderx, vmxnet3
>
> So the overwhelming practice is that the features.rst description is wrong!
>
You are right.
What about update the 'features.rst', and extend the definition of
'Stats per queue' mapping + queue stats in basic stats or extended stats.
This will be make name of the feature more intuitive.
More information about the dev
mailing list