[PATCH] hash: separate param checks in hash create func

Stephen Hemminger stephen at networkplumber.org
Mon Oct 7 23:08:17 CEST 2024


On Fri, 26 Jul 2024 14:54:43 +0000
Niall Meade <niall.meade at intel.com> wrote:

> -		HASH_LOG(ERR, "%s has invalid parameters", __func__);
> +		HASH_LOG(ERR, "%s has invalid parameters, entries must be "
> +		 "in the range %d to %d inclusive", __func__,
> +		  RTE_HASH_BUCKET_ENTRIES, RTE_HASH_ENTRIES_MAX);

Suggest shorter wording and don't break messages across lines, it makes it
harder for the user to search for them. Suggest messages like:

		HASH_LOG(ERR, "%s() %u entries outside of range [%u..%u]",
			__func__, params->entries, 
			RTE_HASH_BUCKET_ENTRIES, RTE_HASH_ENTRIES_MAX);

Shorter is better.


More information about the dev mailing list