[PATCH v4 2/4] cryptodev: add ec points to sm2 op

[Kusztal, ArkadiuszX]

> -----Original Message-----
> From: Stephen Hemminger <stephen at networkplumber.org>
> Sent: Tuesday, October 8, 2024 11:09 PM
> To: Kusztal, ArkadiuszX <arkadiuszx.kusztal at intel.com>
> Cc: dev at dpdk.org; gakhil at marvell.com; Dooley, Brian
> <brian.dooley at intel.com>
> Subject: Re: [PATCH v4 2/4] cryptodev: add ec points to sm2 op
> 
> On Tue, 8 Oct 2024 21:00:50 +0000
> "Kusztal, ArkadiuszX" <arkadiuszx.kusztal at intel.com> wrote:
> 
> > Hi Stephen,
> >
> > > -----Original Message-----
> > > From: Stephen Hemminger <stephen at networkplumber.org>
> > > Sent: Tuesday, October 8, 2024 10:46 PM
> > > To: Kusztal, ArkadiuszX <arkadiuszx.kusztal at intel.com>
> > > Cc: dev at dpdk.org; gakhil at marvell.com; Dooley, Brian
> > > <brian.dooley at intel.com>
> > > Subject: Re: [PATCH v4 2/4] cryptodev: add ec points to sm2 op
> > >
> > > On Tue,  8 Oct 2024 19:14:31 +0100
> > > Arkadiusz Kusztal <arkadiuszx.kusztal at intel.com> wrote:
> > >
> > > > +	RTE_CRYPTO_SM2_PARTIAL,
> > > > +	/**<
> > > > +	 * PMD does not support the full process of the
> > > > +	 * SM2 encryption/decryption, but the elliptic
> > > > +	 * curve part only
> > >
> > > Couldn't this just be:
> > > 	/**< PMD only supports elliptic curve */
> >
> > SM2 encryption involves several steps: random number generation, hashing,
> some trivial xor's etc, and calculation of elliptic curve points, what I meant here
> is that only this EC calculation will be performed.
> > But when I read it now, I probably may need to add some more clarity to it.
> 
> 
> My point is what developers write tends to be overly wordy and redundant.
> Comments and documentation should be as succinct as possible.

I agree, I will change it to the more technical/precise.