[PATCH 1/1] net/mlx5: show rx/tx descriptor ring limitations in rte_eth_dev_info

Stephen Hemminger stephen at networkplumber.org
Thu Oct 10 02:18:53 CEST 2024


On Mon, 17 Jun 2024 07:18:58 +0000
Slava Ovsiienko <viacheslavo at nvidia.com> wrote:

> Hi, Igor
> 
> Thank you for the patch.
> 
> 1. The absolute max descriptor number supported by ConnectX hardware is 32768.
> 2. The actual max descriptor number supported by the port (and its related representors)
>     reported in log_max_wq_sz in HCA.caps.  This value should be queried and save in mlx5_devx_cmd_query_hca_attr() routine.
> 3. mlx5_rx_queue_pre_setup() should check requested descriptor number and reject if it exceeds log_max_wq_sz
> 4. Please, format your patch according to the "fix" template.
> 
> With best regards,
> Slava


Marking this patch as Changes Requested.
Yes, this comment expands the scope of the original patch; but if this part of the mlx5
is going to change, might as well get it right.


More information about the dev mailing list