[PATCH 10/10] net/nfp: fix memory leak in VF initialization logic

Chaoyong He chaoyong.he at corigine.com
Fri Oct 11 04:38:23 CEST 2024


> On Thu, 10 Oct 2024 17:17:16 +0800
> Chaoyong He <chaoyong.he at corigine.com> wrote:
> 
> > Fix one memory leak problem in the logic of VF initialization.
> >
> > Fixes: d81e2b514dc9 ("net/nfp: move device info into process private
> > data")
> > Cc: stable at dpdk.org
> >
> > Signed-off-by: Chaoyong He <chaoyong.he at corigine.com>
> > Reviewed-by: Long Wu <long.wu at corigine.com>
> > Reviewed-by: Peng Zhang <peng.zhang at corigine.com>
> > ---
> 
> The code as is looks fine, but would have been better to use rte_calloc() when
> allocating eth_xstats_base.

Yes, I think what you said is better.
Will do it in next version.
Thanks for your review.

> 
> Acked-by: Stephen Hemminger <stephen at networkplumber.org>


More information about the dev mailing list