[PATCH v3] fib: network byte order IPv4 lookup
David Marchand
david.marchand at redhat.com
Fri Oct 11 16:33:47 CEST 2024
On Fri, Oct 11, 2024 at 1:29 PM David Marchand
<david.marchand at redhat.com> wrote:
> > @@ -214,6 +215,7 @@ rte_fib_create(const char *name, int socket_id, struct rte_fib_conf *conf)
> > rte_strlcpy(fib->name, name, sizeof(fib->name));
> > fib->rib = rib;
> > fib->type = conf->type;
> > + fib->flags = conf->flags;
>
> In addition to Robin comments, I also have a concern on the
> extensibility aspect.
>
> conf->flags must be validated against known flags.
> Otherwise existing applications may pass wrong stuff and "work fine",
> until the day we had one more flag.
>
And about this flag field, please update release notes and remove the
associated deprecation notice.
Thank you.
--
David Marchand
More information about the dev
mailing list