[PATCH] eal: increase max file descriptor for secondary process device

[David Marchand]

On Thu, Oct 10, 2024 at 11:51 AM David Marchand
<david.marchand at redhat.com> wrote:
>
> On Thu, Sep 5, 2024 at 6:22 PM Stephen Hemminger
> <stephen at networkplumber.org> wrote:
> >
> > The TAP and XDP driver both are limited to only 8 queues when
> > because of the small limit imposed by EAL. Increase the limit
> > now since this release allows changing ABI.
> >
> > Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
>
> Applied, thanks.

I suspect this triggered some coverity hiccup:

*** CID 445386:  Memory - illegal accesses  (OVERRUN)
/drivers/net/tap/rte_eth_tap.c
: 2401 in tap_mp_sync_queues()
2395                    TAP_LOG(ERR, "Number of rx/tx queues %u
exceeds max number of fds %u",
2396                            dev->data->nb_rx_queues, RTE_MP_MAX_FD_NUM);
2397                    return -1;
2398            }
2399
2400            for (queue = 0; queue < dev->data->nb_rx_queues; queue++) {
>>>     CID 445386:  Memory - illegal accesses  (OVERRUN)
>>>     Overrunning array "process_private->fds" of 16 4-byte elements at element index 252 (byte offset 1011) using index "queue" (which evaluates to 252).
2401                    reply.fds[reply.num_fds++] =
process_private->fds[queue];
2402                    reply_param->q_count++;
2403            }
2404
2405            /* Send reply */
2406            strlcpy(reply.name, request->name, sizeof(reply.name));

Can you have a look?

Thanks.


-- 
David Marchand