[PATCH v4 01/47] net/bnxt: tf_core: fix wc tcam multi slice delete issue

Stephen Hemminger stephen at networkplumber.org
Mon Oct 14 21:41:32 CEST 2024


On Fri,  4 Oct 2024 23:22:52 +0530
Sriharsha Basavapatna <sriharsha.basavapatna at broadcom.com> wrote:

> From: Shahaji Bhosle <sbhosle at broadcom.com>
> 
> FW tries to update the HWRM request data in the
> delete case to update the mode bit and also
> update invalid profile id. This update only
> happens when the data is send over DMA. HWRM
> requests are read only buffers and cannot be
> updated. So driver now will always send WC
> tcam set message over DMA channel.
> 
> Update tunnel alloc apis to provide error message.
> 
> Fixes: ca5e61bd562d ("net/bnxt: support EM and TCAM lookup with table scope")
> Reviewed-by: Randy Schacher <stuart.schacher at broadcom.com>
> Reviewed-by: Kishore Padmanabha <kishore.padmanabha at broadcom.com>
> Signed-off-by: Shahaji Bhosle <sbhosle at broadcom.com>
> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna at broadcom.com>
> Reviewed-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
> ---

The patch series needs to be rebased, there is some fuzz and git doesn't like to apply.

Also, not every patch builds. For example after applying the first patch
the build fails with:


../drivers/net/bnxt/tf_ulp/bnxt_tf_pmd_shim.c: In function ‘bnxt_tunnel_dst_port_alloc’:
../drivers/net/bnxt/tf_ulp/bnxt_tf_pmd_shim.c:40:17: error: implicit declaration of function ‘PMD_DRV_LOG’; did you mean ‘PMD_DRV_LOG_LINE’? [-Wimplicit-function-declaration]
   40 |                 PMD_DRV_LOG(ERR, "Tunnel type:%d alloc failed for port:%d error:%s\n",
      |                 ^~~~~~~~~~~
      |                 PMD_DRV_LOG_LINE
../drivers/net/bnxt/tf_ulp/bnxt_tf_pmd_shim.c:40:17: warning: nested extern declaration of ‘PMD_DRV_LOG’ [-Wnested-externs]
../drivers/net/bnxt/tf_ulp/bnxt_tf_pmd_shim.c:40:29: error: ‘ERR’ undeclared (first use in this function)
   40 |                 PMD_DRV_LOG(ERR, "Tunnel type:%d alloc failed for port:%d error:%s\n",
      |                             ^~~
../drivers/net/bnxt/tf_ulp/bnxt_tf_pmd_shim.c:40:29: note: each undeclared identifier is reported only once for each function it appears in
../drivers/net/bnxt/tf_ulp/bnxt_tf_pmd_shim.c: In function ‘bnxt_pmd_global_tunnel_set’:
../drivers/net/bnxt/tf_ulp/bnxt_tf_pmd_shim.c:601:37: error: ‘ERR’ undeclared (first use in this function)
  601 |                         PMD_DRV_LOG(ERR, "Tunnel type:%d alloc failed for port:%d error:%s\n",
      |                                     ^~~
[16/2343] Compiling C object drivers/libtmp_rte_net_bnxt.a.p/net_bnxt_tf_ulp_ulp_mapper.c.o


More information about the dev mailing list