[v7 02/15] dma/dpaa2: refactor driver code

Hemant Agrawal hemant.agrawal at oss.nxp.com
Wed Oct 16 07:15:44 CEST 2024


On 16-10-2024 10:43, Stephen Hemminger wrote:
> On Wed, 16 Oct 2024 10:39:40 +0530
> Hemant Agrawal <hemant.agrawal at oss.nxp.com> wrote:
>
>>> diff --git a/devtools/build-dict.sh b/devtools/build-dict.sh
>>> index a8cac49029..d503fb52fc 100755
>>> --- a/devtools/build-dict.sh
>>> +++ b/devtools/build-dict.sh
>>> @@ -17,6 +17,8 @@ sed '/^..->/d' |
>>>    sed '/^uint->/d' |
>>>    sed "/^doesn'->/d" |
>>>    sed '/^wasn->/d' |
>>> +sed '/^ser->/d' |
>>> +sed '/^fle->/d' |
>>>    
>>>    # print to stdout
>>>    cat
>> Hi Stephen,
>>
>>       It may not be good idea to add these.  For DPAA these are proper
>> keyboard, however for others - *fle* can be a spelling mistake of *file*
>>
>> Regards,
>>
>> Hemant
>
> But every patch gets tagged as checkpatch error now.
> Or change the variable names?

Changing variable name is not feasible, as it align with base driver and 
register names.

If you don't want to ignore the checkpatch errors, than we can go with 
your suggestion.



More information about the dev mailing list