[PATCH v26 05/15] eal: do not duplicate rte_init_alert() messages

[David Marchand]

Hello,

On Wed, Oct 16, 2024 at 10:24 PM Stephen Hemminger
<stephen at networkplumber.org> wrote:
>
> The message already goes through logging, and does not need
> to be printed on stderr. Message level should be ALERT
> to match function name.
>
> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> Acked-by: Tyler Retzlaff <roretzla at linux.microsoft.com>
> Acked-by: Morten Brørup <mb at smartsharesystems.com>
> Acked-by: Bruce Richardson <bruce.richardson at intel.com>
> Acked-by: Chengwen Feng <fengchengwen at huawei.com>
> ---
>  lib/eal/freebsd/eal.c | 3 +--
>  lib/eal/linux/eal.c   | 3 +--
>  2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c
> index d3b40e81d8..7b974608e4 100644
> --- a/lib/eal/freebsd/eal.c
> +++ b/lib/eal/freebsd/eal.c
> @@ -529,8 +529,7 @@ rte_eal_iopl_init(void)
>
>  static void rte_eal_init_alert(const char *msg)
>  {
> -       fprintf(stderr, "EAL: FATAL: %s\n", msg);
> -       EAL_LOG(ERR, "%s", msg);
> +       EAL_LOG(ALERT, "%s", msg);
>  }
>
>  /* Launch threads, called at application init(). */
> diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c
> index 40d750ed0d..c53a051405 100644
> --- a/lib/eal/linux/eal.c
> +++ b/lib/eal/linux/eal.c
> @@ -830,8 +830,7 @@ rte_eal_iopl_init(void)
>
>  static void rte_eal_init_alert(const char *msg)
>  {
> -       fprintf(stderr, "EAL: FATAL: %s\n", msg);
> -       EAL_LOG(ERR, "%s", msg);
> +       EAL_LOG(ALERT, "%s", msg);
>  }
>
>  /*

Any reason why Windows was not changed?

I can add the missing bit when applying.


-- 
David Marchand