[PATCH v2 11/18] net/r8169: implement Rx path

[Stephen Hemminger]

On Fri, 18 Oct 2024 02:02:47 +0000
王颢 <howard_wang at realsil.com.cn> wrote:

> Dear Stephen,
> 
> These CamelCase are from our linux kernel drivers. In order to maintain consistency with Linux kernel drivers and facilitate maintenance, our DPDK PMD has adopted this naming convention. May we continue using CamelCase?
> 
> Best Regards,
> Howard Wang

No problem with most of the CamelCase in this driver.
But the Jumbo_Frame_9k can be replaced with something like.

#define ETH_HLEN	RTE_ETHER_HDR_LEN
#define VLAN_HLEN	RTE_VLAN_HLEN
#define JUMBO_9K	(9 * 1024 - ETH_HLEN - VLAN_HLEN - RTE_ETHER_CRC_LEN)

Also, the Linux kernel driver has more complex handling of max mtu.
It bases max mtu on the Phy type, the DPDK driver may need the same treatment.