[PATCH v4 01/42] devtools: forbid use of strerror
Dengdui Huang
huangdengdui at huawei.com
Wed Oct 23 10:28:11 CEST 2024
The function strerror() is insecure in a multi-thread environment.
rte_strerror() has been provided in DPDK to replace it.
Signed-off-by: Dengdui Huang <huangdengdui at huawei.com>
Acked-by: Chengwen Feng <fengchengwen at huawei.com>
Acked-by: Morten Brørup <mb at smartsharesystems.com>
---
devtools/checkpatches.sh | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index d860f19045..078d5714da 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -209,6 +209,14 @@ check_forbidden_additions() { # <patch>
-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
"$1" || res=1
+ # refrain from using strerror() for drivers and libs
+ awk -v FOLDERS="lib drivers" \
+ -v EXPRESSIONS="\\\sstrerror\\\(" \
+ -v RET_ON_FAIL=1 \
+ -v MESSAGE='Using strerror, prefer rte_strerror' \
+ -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
+ "$1" || res=1
+
# refrain from using RTE_LOG_REGISTER for drivers and libs
awk -v FOLDERS='lib drivers' \
-v EXPRESSIONS='\\<RTE_LOG_REGISTER\\>' \
--
2.33.0
More information about the dev
mailing list