[PATCH v2 08/73] net/ntnic: add create/destroy implementation for NT flows

[Serhii Iliushyk]

>On 22.10.2024, 20:21, "Stephen Hemminger" wrote:
>
>
>On Tue, 22 Oct 2024 18:54:25 +0200
>Serhii Iliushyk <sil-plv at napatech.com <mailto:sil-plv at napatech.com> <mailto:sil-plv at napatech.com <mailto:sil-plv at napatech.com>> <mailto:sil-plv at napatech.com <mailto:sil-plv at napatech.com> <mailto:sil-plv at napatech.com <mailto:sil-plv at napatech.com>>> <mailto:sil-plv at napatech.com <mailto:sil-plv at napatech.com> <mailto:sil-plv at napatech.com <mailto:sil-plv at napatech.com>> <mailto:sil-plv at napatech.com <mailto:sil-plv at napatech.com> <mailto:sil-plv at napatech.com <mailto:sil-plv at napatech.com>>>>> wrote:
>
>
>> diff --git a/drivers/net/ntnic/include/flow_api.h b/drivers/net/ntnic/include/flow_api.h
>> index 748da89262..667dad6d5f 100644
>> --- a/drivers/net/ntnic/include/flow_api.h
>> +++ b/drivers/net/ntnic/include/flow_api.h
>> @@ -68,6 +68,9 @@ struct flow_nic_dev {
>> uint32_t flow_unique_id_counter;
>> /* linked list of all flows created on this NIC */
>> struct flow_handle *flow_base;
>> + /* linked list of all FLM flows created on this NIC */
>> + struct flow_handle *flow_base_flm;
>> + pthread_mutex_t flow_mtx;
>
>
>
>
>Use of pthread_mutex makes the driver unportable to Windows, and
>will block the the thread in case of contention. And it will not
>handle the case of primary/secondary process.
>
>
>Prefer use of DPDK spinlock if possible.
>


Hi Stephen!


The current version of our PMD supports only Linux x86_64 platforms.
Due to this, we have added a special condition to the meson.build file:

```
if not is_linux or not dpdk_conf.has('RTE_ARCH_X86_64')
build = false
reason = 'only supported on x86_64 Linux'
subdir_done()
endif
```

We prefer to use pthread for the current patch set and fix it later.

Best regards,
Serhii


NOTE: Please ignore the disclaimer. We are working on fix it.