[PATCH v2] net/bnxt: fix issue reading sff8436 sfp eeproms

[Ajit Khaparde]

On Mon, Aug 12, 2024 at 3:34 AM Peter Morrow <pdmorrow at gmail.com> wrote:
>
> From: Peter Morrow <peter at graphiant.com>
>
> If a SFP which supports SFF-8436 is present then
> currently the DDM information present in the eeprom
> is not read. Furthermore bnxt_get_module_eeprom()
> will return -EINVAL for these eeproms since the
> length of these eeproms is 512 bytes but we are
> only ever selecting 2 pages (256 bytes) to read.
>
> Signed-off-by: Peter Morrow <peter at graphiant.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
Patch applied to dpdk-next-net-brcm for-next-net branch.

> ---
> Corrected sob email address.
>
>  drivers/net/bnxt/bnxt_ethdev.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
> index e63febe782..8c4608a1b9 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -4130,7 +4130,6 @@ static int bnxt_get_module_eeprom(struct rte_eth_dev *dev,
>
>         switch (module_info[0]) {
>         case SFF_MODULE_ID_SFP:
> -               module_info[SFF_DIAG_SUPPORT_OFFSET] = 0;
>                 if (module_info[SFF_DIAG_SUPPORT_OFFSET]) {
>                         pg_addr[2] = I2C_DEV_ADDR_A2;
>                         pg_addr[3] = I2C_DEV_ADDR_A2;
> --
> 2.39.2
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4218 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://mails.dpdk.org/archives/dev/attachments/20241023/b5c9a412/attachment.bin>