[PATCH 4/6] vhost: refactor VDUSE reconnection log mapping
David Marchand
david.marchand at redhat.com
Thu Oct 24 09:55:29 CEST 2024
On Wed, Oct 23, 2024 at 9:04 PM Maxime Coquelin
<maxime.coquelin at redhat.com> wrote:
> >> +static int
> >> +vduse_reconnect_log_map(const char *dev_name, struct vhost_reconnect_data **reco_log, bool create)
> >
> > You can pass struct virtio_net *dev instead of patch 6.
>
> At patch 4, the struct virtio_net *dev has not yet been allocated when
> this function is called.
Ah yes, I missed this point.
>
> Or, maybe you mean I should squash patch 6 with this one?
No keep it as is, moving patches or squashing does not improve the diff.
--
David Marchand
More information about the dev
mailing list