[EXTERNAL] Re: [PATCH v5 2/9] raw/cnxk_rvu_lf: add API to get NPA/SSO pffunc

[Akhil Goyal]

Hi Stephen,
> On Thu, 24 Oct 2024 18:47:52 +0530
> Akhil Goyal <gakhil at marvell.com> wrote:
> 
> > +/**
> > + * @file cnxk_rvu_lf_driver.h
> > + *
> > + * Marvell RVU LF raw PMD specific structures and interface
> > + *
> > + * This API allows external driver/application to manage RVU LF device
> > + * in user space along with installing interrupt handlers for low latency signal
> processing.
> > + */
> > +
> > +#ifdef __cplusplus
> > +extern "C" {
> > +#endif
> > +
> > +/**
> > + * Obtain NPA PF func
> > + *
> > + * @return
> > + *   Returns NPA pf_func on success, 0 in case of invalid pf_func.
> > + */
> > +__rte_internal
> > +uint16_t rte_pmd_rvu_lf_npa_pf_func_get(void);
> > +
> > +/**
> > + * Obtain SSO PF func
> > + *
> > + * @return
> > + *   Returns SSO pf_func on success, 0 in case of invalid pf_func.
> > + */
> > +__rte_internal
> > +uint16_t rte_pmd_rvu_lf_sso_pf_func_get(void);
> > +
> > +#ifdef __cplusplus
> > +}
> > +#endif
> 
> If these functions are used by applications, they should be in experimental
> section not internal. Applications shouldn't be calling internal routines.

These are meant to be used by external out of tree drivers using the enable_driver_sdk meson option.
Hence should be internal.