[PATCH v3 2/2] common/mlx5: reduce HCA attribute type sizes
Slava Ovsiienko
viacheslavo at nvidia.com
Mon Oct 28 16:48:08 CET 2024
Thank you for the patch.
Acked-by: Viacheslav Ovsiienko <viacheslavo at nvidia.com>
> -----Original Message-----
> From: Igor Gutorov <igootorov at gmail.com>
> Sent: Wednesday, August 7, 2024 11:44 PM
> To: dev at dpdk.org
> Cc: Igor Gutorov <igootorov at gmail.com>
> Subject: [PATCH v3 2/2] common/mlx5: reduce HCA attribute type sizes
>
> A number of `log_max_*` fields' types are unnecessarily large, and can be
> reduced to `uint8_t`.
>
> Signed-off-by: Igor Gutorov <igootorov at gmail.com>
> ---
> drivers/common/mlx5/mlx5_devx_cmds.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/common/mlx5/mlx5_devx_cmds.h
> b/drivers/common/mlx5/mlx5_devx_cmds.h
> index 2ad9e5414f..f523bf8529 100644
> --- a/drivers/common/mlx5/mlx5_devx_cmds.h
> +++ b/drivers/common/mlx5/mlx5_devx_cmds.h
> @@ -268,10 +268,10 @@ struct mlx5_hca_attr {
> struct mlx5_hca_flex_attr flex;
> struct mlx5_hca_crypto_mmo_attr crypto_mmo;
> uint8_t log_max_wq_sz;
> - int log_max_qp_sz;
> - int log_max_cq_sz;
> - int log_max_qp;
> - int log_max_cq;
> + uint8_t log_max_qp_sz;
> + uint8_t log_max_cq_sz;
> + uint8_t log_max_qp;
> + uint8_t log_max_cq;
> uint32_t log_max_pd;
> uint32_t log_max_mrw_sz;
> uint32_t log_max_srq;
> --
> 2.45.2
More information about the dev
mailing list