[PATCH 3/5] dts: use Pydantic in the configuration

[Luca Vizzarro]

Likewise, thank you Juraj for the comments.

Most if not all suggestions have been applied in the new versions.

On 17/09/2024 12:13, Juraj Linkeš wrote:
>> - the config schema is no longer used for validation but kept as an
>>    alternative format for the developer
> 
> If it's not used, we should remove it right away (in this patch). I see 
> that it's updated in v5, but we can just add it back.

You are right, and this is now removed in the new versions.

>> diff --git a/dts/framework/runner.py b/dts/framework/runner.py
>> @@ -231,10 +234,10 @@ def _get_test_suites_with_cases(
>>           test_suites_with_cases = []
>>           for test_suite_config in test_suite_configs:
>> -            test_suite_class = 
>> self._get_test_suite_class(test_suite_config.test_suite)
>> +            test_suite_class = 
>> self._get_test_suite_class(test_suite_config.test_suite_name)
> 
> We've already done all the validation and importing at this point and we 
> should be able to use test_suite_config.test_suite_spec, right? The same 
> is true for TestSuiteWithCases, which holds the same information.

This is correct.

> Looks like you removed _get_test_suite_class in a subsequent patch, but 
> we should think about getting rid of TestSuiteWithCases, as it was 
> conceived to do what TestSuiteSpec is doing.

I believe the two have different ideas, one just describes the 
specification, and one extracts a subset for runtime. It is a good idea 
to unify stuff anyways, so it may something we could do in the near future.