[PATCH V2 3/7] net/mlx5: add new devargs to control probe optimization

[Stephen Hemminger]

On Tue, 29 Oct 2024 16:27:25 +0800
"Minggang(Gavin) Li" <gavinl at nvidia.com> wrote:

> On 10/28/2024 11:47 PM, Stephen Hemminger wrote:
> > On Mon, 28 Oct 2024 11:18:18 +0200
> > "Minggang Li(Gavin)" <gavinl at nvidia.com> wrote:
> >  
> >> +- ``probe_opt_en`` parameter [int]
> >> +
> >> +  A non-zero value optimizes the probe process, especially for large scale.
> >> +  PMD will hold the IB device information internally and reuse it.
> >> +
> >> +  By default, the PMD will set this value to 0.
> >> +  
> > Is there ever a case where this should not be used?
> >
> > It would be better to just detect and use it if available.
> > This driver does not need more options...  
> The new mechanism, which is required by few users, so we would not break 
> production and with the option we encourage to use new way only those 
> who actually needs. Once we see the new way is reliable - we will change 
> the default value.

I understand that philosophy but it leads to a maze of technical debt.
Has a full suite of tests been done with both settings of the option?
Has both values been tested on all combinations of platforms and OS releases?

My point is every option adds to the necessary test matrix geometrically!