[PATCH v1] net/macb: add new driver

[Stephen Hemminger]

On Wed, 30 Oct 2024 09:53:29 +0000
liwencheng <liwencheng at phytium.com.cn> wrote:

> diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
> index 80c35f9..b4db58b 100755
> --- a/usertools/dpdk-devbind.py
> +++ b/usertools/dpdk-devbind.py

This should be a separate patch.

Please run a python checker like flake8 and cleanup.

$ flake8 --max-line-length=100 dpdk-devbind.py 
dpdk-devbind.py:156:1: E302 expected 2 blank lines, found 1
dpdk-devbind.py:167:1: E302 expected 2 blank lines, found 1
dpdk-devbind.py:353:1: E302 expected 2 blank lines, found 1
dpdk-devbind.py:374:1: E302 expected 2 blank lines, found 1
dpdk-devbind.py:398:1: E302 expected 2 blank lines, found 1
dpdk-devbind.py:408:5: E265 block comment should start with '# '
dpdk-devbind.py:415:25: E127 continuation line over-indented for visual indent
dpdk-devbind.py:421:21: E128 continuation line under-indented for visual indent
dpdk-devbind.py:428:13: E128 continuation line under-indented for visual indent
dpdk-devbind.py:435:17: E127 continuation line over-indented for visual indent
dpdk-devbind.py:437:62: E225 missing whitespace around operator
dpdk-devbind.py:439:1: E302 expected 2 blank lines, found 1
dpdk-devbind.py:629:32: E231 missing whitespace after ','


Also, it would probably better to encourage users to use another tool
like driverctl, rather than adding more complexity to dpdk-devbind.
That was the response I got when looking to add vmbus support to devbind.