[PATCH] net/ena: revert redefining memcpy

Brandes, Shai shaibran at amazon.com
Thu Sep 12 16:53:24 CEST 2024



> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit at amd.com>
> Sent: Thursday, September 12, 2024 11:20 AM
> To: Tyler Retzlaff <roretzla at linux.microsoft.com>; Stephen Hemminger
> <stephen at networkplumber.org>; Brandes, Shai <shaibran at amazon.com>
> Cc: dev at dpdk.org; Schmeilin, Evgeny <evgenys at amazon.com>; Beider, Ron
> <rbeider at amazon.com>; Bernstein, Amit <amitbern at amazon.com>;
> Atrash, Wajeeh <atrwajee at amazon.com>; Chauskin, Igor
> <igorch at amazon.com>; Michal Krawczyk <mk at semihalf.com>; Artur Rojek
> <ar at semihalf.com>
> Subject: RE: [EXTERNAL] [PATCH] net/ena: revert redefining memcpy
> 
> CAUTION: This email originated from outside of the organization. Do not click
> links or open attachments unless you can confirm the sender and know the
> content is safe.
> 
> 
> 
> On 9/12/2024 6:12 AM, Tyler Retzlaff wrote:
> > On Mon, Aug 12, 2024 at 08:34:17AM -0700, Stephen Hemminger wrote:
> >> Redefining memcpy as rte_memcpy has no performance gain on current
> >> compilers, and introduced bugs like this one where
> >> rte_memcpy() will be detected as referencing past the destination.
> >>
> >> Bugzilla ID: 1510
> >> Fixes: 142778b3702a ("net/ena: switch memcpy to optimized version")
> >>
> >> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> >> ---
> >
> > Acked-by: Tyler Retzlaff <roretzla at linux.microsoft.com>
> >
> 
> Hi Shai,
> 
> Did you have any chance to check/test this patch?
[Brandes, Shai] sorry, I missed this. The change will be tested by the upcoming Monday is this is fine.


More information about the dev mailing list