[PATCH] net/ena: revert redefining memcpy

Stephen Hemminger stephen at networkplumber.org
Mon Sep 16 17:11:40 CEST 2024


On Mon, 16 Sep 2024 06:33:26 +0000
"Brandes, Shai" <shaibran at amazon.com> wrote:

> > Did you have any chance to check/test this patch?  
> [Brandes, Shai] We are currently conducting tests and will provide an update shortly. In the meantime, could you advise whether it is recommended to entirely avoid using rte_memcpy in our driver, considering we have direct calls to it?

There is a long term goal to remove rte_memcpy(). It exists only as workaround for
cases where older compilers do not produce optimium code. 

When rte_memcpy() is used the checks done by fortify, gcc, coverity etc are
less and there is higher probability of bugs going undetected.

My current recommendation is to only use rte_memcpy() in the data path and for
variable size data items.


More information about the dev mailing list