[PATCH] vhost: fix offset while mmaping log base address

[Maxime Coquelin]

On 7/8/24 08:57, BillXiang wrote:
> From: BillXiang <xiangwencheng at dayudpu.com>
> 
> For sanity the offset should be the last parameter of mmap.
> 
> Fixes: fbc4d24 ("vhost: fix offset while mmaping log base address")
> Signed-off-by: BillXiang <xiangwencheng at dayudpu.com>
> ---
>   lib/vhost/vhost_user.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
> index 5f470da38a..0893ae80bb 100644
> --- a/lib/vhost/vhost_user.c
> +++ b/lib/vhost/vhost_user.c
> @@ -2399,7 +2399,7 @@ vhost_user_set_log_base(struct virtio_net **pdev,
>   	 * mmap from 0 to workaround a hugepage mmap bug: mmap will
>   	 * fail when offset is not page size aligned.
>   	 */
> -	addr = mmap(0, size + off, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);
> +	addr = mmap(0, size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, off);
>   	alignment = get_blk_size(fd);
>   	close(fd);
>   	if (addr == MAP_FAILED) {

Fixed the fixes tag and Cc'ed stable.

Applied to next-virtio/for-next-net.

Thanks,
Maxime