[PATCH v3] dts: fix runner target in the Dockerfile

Juraj Linkeš juraj.linkes at pantheon.tech
Thu Sep 19 16:35:09 CEST 2024



On 19. 9. 2024 16:24, jspewock at iol.unh.edu wrote:
> From: Jeremy Spewock <jspewock at iol.unh.edu>
> 
> Currently the runner target in the Dockerfile attempts to run the
> `poetry install` command when building the image, but this fails due to
> poetry not being found in the container. Poetry is installed in a
> previous step with pipx, but doing so adds the binary to use poetry to
> ~/.local/bin which isn't present in the PATH variable in the container
> image. The command `pipx ensurepath` fixes this issue in most cases, but
> it requires a restart of the shell in order for the changes to take
> place which is not something that can be done in the runner target. To
> solve this problem this patch manually adds ~/.local/bin to PATH in the
> runner target.
> 
> Additionally, the command for installing poetry in the runner target
> uses a depreciated flag, and the --revision parameter does not work with
> the runner target. To address these problems the --no-dev flag is
> removed in this patch and replaced with the new method of doing the same
> thing and git is added to the base target of the image. The CMD of the
> runner target is also replaced with an ENTRYPOINT for ease of use.
> 
> Fixes: 19082c1fac43 ("dts: add Dockerfile")
> Cc: juraj.linkes at pantheon.tech
> 
> Signed-off-by: Jeremy Spewock <jspewock at iol.unh.edu>

Applied to next-dts after adding review-by tags. Thanks.



More information about the dev mailing list