[PATCH v4 1/1] dts: Remove XML-RPC server for Scapy TG and instead use PythonShell

Juraj Linkeš juraj.linkes at pantheon.tech
Fri Sep 27 11:35:03 CEST 2024


>>> +    Note that the order of inheritance is important for this class. In order to instantiate this
>>> +    class, the abstract methods of :class:`~.capturing_traffic_generator.CapturingTrafficGenerator`
>>> +    must be implemented. Since some of these methods are implemented in the underlying interactive
>>> +    shell, according to Python's Method Resolution Order (MRO), the interactive shell must come
>>> +    first.
>>
>> I didn't notice this before. Is this because of the close() method? Do
>> we need to add any special steps to close the TG? Closing the
>> interactive session should be enough, but I wanted to check with you.
> 
> Yes it is because of the close method in the traffic generator. I
> think closing the shell should be all we need to do really, there
> isn't anything else this traffic generator is really using on the
> host.
> 

Ok, thanks. We can keep it this way then.



More information about the dev mailing list