[PATCH] net/igc: fix xstats name

Deng, KaiwenX kaiwenx.deng at intel.com
Thu Apr 10 08:57:41 CEST 2025



> -----Original Message-----
> From: Stephen Hemminger <stephen at networkplumber.org>
> Sent: Wednesday, April 9, 2025 11:56 AM
> To: Deng, KaiwenX <kaiwenx.deng at intel.com>
> Cc: dev at dpdk.org; stable at dpdk.org; Ferruh Yigit <ferruh.yigit at intel.com>;
> Alvin Zhang <alvinx.zhang at intel.com>
> Subject: Re: [PATCH] net/igc: fix xstats name
> 
> On Wed,  9 Apr 2025 09:07:11 +0800
> Kaiwen Deng <kaiwenx.deng at intel.com> wrote:
> 
> > The xstats name needs to be changed correctly
> > tx_size_1023_to_max_packets should be tx_size_1024_to_max_packets.
> >
> > Fixes: e6defdfddc3b ("net/igc: enable statistics")
> > Cc: stable at dpdk.org
> >
> > Signed-off-by: Kaiwen Deng <kaiwenx.deng at intel.com>
> > ---
> >  drivers/net/intel/e1000/igc_ethdev.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/intel/e1000/igc_ethdev.c
> > b/drivers/net/intel/e1000/igc_ethdev.c
> > index e712cfcf7c..68444e4fba 100644
> > --- a/drivers/net/intel/e1000/igc_ethdev.c
> > +++ b/drivers/net/intel/e1000/igc_ethdev.c
> > @@ -181,7 +181,7 @@ static const struct rte_igc_xstats_name_off
> rte_igc_stats_strings[] = {
> >  	{"tx_size_256_to_511_packets", offsetof(struct e1000_hw_stats,
> ptc511)},
> >  	{"tx_size_512_to_1023_packets", offsetof(struct e1000_hw_stats,
> >  		ptc1023)},
> > -	{"tx_size_1023_to_max_packets", offsetof(struct e1000_hw_stats,
> > +	{"tx_size_1024_to_max_packets", offsetof(struct e1000_hw_stats,
> >  		ptc1522)},
> >  	{"tx_multicast_packets", offsetof(struct e1000_hw_stats, mptc)},
> >  	{"tx_broadcast_packets", offsetof(struct e1000_hw_stats, bptc)},
> 
> 
> Please don't send same patch twice.
Hi Stephen,
Thanks for your review.
The two patches I posted earlier were fixes for the same issue for both igb and igc drivers. 
Now I merged those two patches into one patch to fix the issue.


More information about the dev mailing list