[PATCH 1/2] dts: add packet capture test suite
Dean Marx
dmarx at iol.unh.edu
Thu Apr 10 19:04:55 CEST 2025
On Mon, Mar 31, 2025 at 11:58 AM Thomas Wilks <thomas.wilks at arm.com> wrote:
>
> Add a test suite that tests the packet capture framework
> through the use of dpdk-pdump.
>
> Signed-off-by: Thomas Wilks <thomas.wilks at arm.com>
> Reviewed-by: Luca Vizzarro <luca.vizzarro at arm.com>
> ---
> .../dts/tests.TestSuite_packet_capture.rst | 8 +
> dts/tests/TestSuite_packet_capture.py | 358 ++++++++++++++++++
> 2 files changed, 366 insertions(+)
> create mode 100644 doc/api/dts/tests.TestSuite_packet_capture.rst
> create mode 100644 dts/tests/TestSuite_packet_capture.py
<snip>
> + device_id: str | None = None
> + port: int | None = None
> + queue: Union[int, Literal["*"]] = "*"
> + tx_dev: PurePath | str | None = None
> + rx_dev: PurePath | str | None = None
> + ring_size: int | None = None
> + mbuf_size: int | None = None
> + total_num_mbufs: int | None = None
One small thing I noticed here is that you're using Union for the
queue and pipes for the rest of the declarations. queue: int |
Literal["*"] = "*" would be the same thing functionally, and it would
save you an import.
Reviewed-by: Dean Marx <dmarx at iol.unh.edu>
More information about the dev
mailing list