[PATCH v6 00/10] enable "app" to be compiled with MSVC
David Marchand
david.marchand at redhat.com
Fri Apr 11 08:49:40 CEST 2025
Hello Andre,
On Mon, Feb 24, 2025 at 5:25 PM Andre Muezerie
<andremue at linux.microsoft.com> wrote:
>
> v6:
> - remove "volatile" and use rte_atomic_xxx to access the RTE_ATOMIC
> qualified lcore_count, which is cleaner than using "volatile".
>
> v5:
> - add "volatile" to declaration of lcore_count in test_ring_perf.c.
>
> v4:
> - add explanation about the expression used in __rte_constant during v3.
>
> v3:
> - use clever expression with _Generic for __rte_constant and use it
> where __builtin_constant_p was being used.
> - use %u in csumonly.c and just cast variables to unsigned int.
>
> v2:
> - use lcore_count as atomic always, not only when RTE_USE_C11_MEM_MODEL
> is set.
> - use PRIu64 in csumonly.c instead of casting variables to int.
>
> Andre Muezerie (10):
> eal: add workaround for __builtin_constant_p
> test_alarm: avoid warning about different qualifiers
> test-pmd: fix printf format string mismatch
> test-pmd: do explicit 64-bit shift to avoid implicit conversion
> test-pmd: avoid undefined behavior
> test-pmd: avoid non-constant initializer
> test-pmd: don't return value from void function
> test/test-pmd: declare lcore_count atomic
> test: add workaround for __builtin_constant_p in test_memcpy_perf
> app: enable app directory to be compiled with MSVC
>
> app/meson.build | 4 ---
> app/test-pmd/cmdline.c | 16 +++++----
> app/test-pmd/cmdline_flow.c | 22 ++++++------
> app/test-pmd/csumonly.c | 23 ++++++------
> app/test-pmd/meson.build | 1 -
> app/test-pmd/testpmd.c | 2 +-
> app/test-pmd/testpmd.h | 2 ++
> app/test-pmd/util.c | 2 +-
> app/test/test_alarm.c | 12 +++----
> app/test/test_memcpy_perf.c | 54 ++++++++++++++---------------
> app/test/test_ring_perf.c | 13 +++----
> lib/eal/include/generic/rte_pause.h | 2 +-
> lib/eal/include/rte_common.h | 34 +++++++++++++++++-
> 13 files changed, 109 insertions(+), 78 deletions(-)
I replaced patch 5 with the alternative that I sent yesterday.
Series applied.
We now have dpdk-test and dpdk-testpmd built with MSVC in the CI.
We are still missing net/null and mempool/ring to do some basic test
like devtools/test-null.sh.
On the other hand, what prevents us from running the fast-tests
testsuite in the CI?
--
David Marchand
More information about the dev
mailing list